<html>
<head><meta charset="utf-8"><title>Triage nags and #75200 · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20nags.20and.20.2375200.html">Triage nags and #75200</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="209550780"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20nags%20and%20%2375200/near/209550780" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20nags.20and.20.2375200.html#209550780">(Sep 09 2020 at 18:40)</a>:</h4>
<p>I was sad to see the response by the author to the <a href="https://github.com/rust-lang/rust/pull/75200#issuecomment-689123704">perf triage comment</a> I left on <a href="https://github.com/rust-lang/rust/issues/75200">#75200</a>. AFAIK, there's no template for such comments, but maybe there should be some front-matter indicating that perf triage is a normal part of contributing to the compiler, and that PRs that don't provide tangible benefits to users should provide some justification if they regress performance.</p>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> do you have any thoughts on the general outline, or on <a href="https://github.com/rust-lang/rust/issues/75200">#75200</a> in particular? I'd like to leave another comment on that PR, since I don't want the author to feel singled-out. I'm sympathetic since A) The increase is barely over the 1% threshold (full builds of cranelift) B) there's no runtime regressions for BTreeMap users C) I am guessing that the increase in instruction counts is purely due to more LLVM IR, which is a pretty high burden to put on standard library maintainers.</p>
<p>OTOH, I suspect that the <code>Handle</code>/<code>NodeRef</code> part of the <code>BTreeMap</code> implementation is already excessively generic, and contributor time would be better spent removing the <code>marker</code> abstraction (it seems to cause safety issues anyway) than doubling down on it.</p>



<a name="209550833"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20nags%20and%20%2375200/near/209550833" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20nags.20and.20.2375200.html#209550833">(Sep 09 2020 at 18:40)</a>:</h4>
<p>It's... a complicated topic</p>



<a name="209550962"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20nags%20and%20%2375200/near/209550962" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20nags.20and.20.2375200.html#209550962">(Sep 09 2020 at 18:42)</a>:</h4>
<p>Yeah, I'm not going to do anything unilaterally here.</p>



<a name="209550995"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20nags%20and%20%2375200/near/209550995" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20nags.20and.20.2375200.html#209550995">(Sep 09 2020 at 18:42)</a>:</h4>
<p>some more context in <a href="https://github.com/rust-lang/rust/pull/73971#issuecomment-687250207">https://github.com/rust-lang/rust/pull/73971#issuecomment-687250207</a> and <a href="https://github.com/rust-lang/rust/pull/74437#issuecomment-689475199">https://github.com/rust-lang/rust/pull/74437#issuecomment-689475199</a> maybe</p>



<a name="209552149"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20nags%20and%20%2375200/near/209552149" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20nags.20and.20.2375200.html#209552149">(Sep 09 2020 at 18:51)</a>:</h4>
<p>(deleted)</p>



<a name="209785457"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20nags%20and%20%2375200/near/209785457" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20nags.20and.20.2375200.html#209785457">(Sep 11 2020 at 14:13)</a>:</h4>
<p>well to be fair, instruction counts <em>aren't</em> necessarily a good predictor for observed performance</p>



<a name="209785483"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20nags%20and%20%2375200/near/209785483" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20nags.20and.20.2375200.html#209785483">(Sep 11 2020 at 14:13)</a>:</h4>
<p>but yeah, the tone of the PR author's response is unfortunate</p>



<a name="209785595"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20nags%20and%20%2375200/near/209785595" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20nags.20and.20.2375200.html#209785595">(Sep 11 2020 at 14:14)</a>:</h4>
<p>I mean, there's ways of reading "but I'm beyond caring" so that it can be taken to mean "do whatever you like here; I'm not going to object if you choose to revert." But that's not really what you had asked them anyway.</p>



<a name="209845157"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20nags%20and%20%2375200/near/209845157" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20nags.20and.20.2375200.html#209845157">(Sep 11 2020 at 23:02)</a>:</h4>
<p>i sense a bit of harshness from the author in a few other places as well (including the ones which joshua linked),I guess they were expecting the entire contribution process to be faster than expected and they got pulled into making changes and resolving conflicts</p>



<a name="209896863"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20nags%20and%20%2375200/near/209896863" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20nags.20and.20.2375200.html#209896863">(Sep 12 2020 at 19:45)</a>:</h4>
<p>This is kind of just a thought on the review process based one one of the things that the author brought up. Maybe when a PR  or changes are requested on the PR, rust highfive puts a message saying if the comments are resolved please update the labels using this command <code>@rustbot </code> essentially the exact command someone can copy paste to set waiting on review label. And it also just lets the user know that this is an Open Source Project and that review can take time. The frequency of this can be tailored to when was the last time the person created a PR or any other factors.</p>
<p>At some point if the user runs the rustbot command to notify that they have applied some fixups as requested, and the PR isn't reviewed for some time (say 1 week after the change in label), it sends a gentle reminder to the person who requested changes. and if say it gets to two weeks or some other arbitary period it maybe requests review from another person similar to how rust-highfive would've when a PR is created without <code>r?</code></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>